Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: support generating web app manifest when using html.appIcon #3219

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

chenjiahan
Copy link
Member

Summary

Previously, html.appIcon lacked support for web app manifests, meaning it was only available on iOS.

For Android devices, we should generate a manifest.webmanifest file to provide information about the web application.

Note that this PR contains a breaking change:

  • before:
export default {
  html: {
    appIcon: './src/icon.png',
  },
};
  • after:
export default {
  html: {
    appIcon: {
      icons: [{ src: './src/icon.png', size: 180 }],
    },
  },
};
  • generating manifest.webmanifest:
export default {
  html: {
    appIcon: {
      name: 'My Website',
      icons: [
        { src: './src/icon-192.png', size: 192 },
        { src: './src/icon-512.png', size: 512 },
      ],
    },
  },
};

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Aug 15, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 68dbfc5
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/66bdd04eff952c000893eac1
😎 Deploy Preview https://deploy-preview-3219--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 86 (🟢 up 12 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan merged commit d986193 into main Aug 15, 2024
10 checks passed
@chenjiahan chenjiahan deleted the refactor_app_icon_0815 branch August 15, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant